fix(indy): async ledger connection issues on iOS

[TheTreek]

Change connectToPools function to sequentially connect to pools. Previously there were issues on iOS because of too many open sockets on this function.

[TimoGlastra]

How is this PR related to #804? Should we add a note to this code explaining why we're doing it in sequence instead of in parallel? Or is this change unrelated to that change?

[TimoGlastra]

Will this also fix the issue with connectToIndyLedgersOnStartup?

[codecov-commenter]

Codecov Report

Merging #803 (2b8ac4b) into main (5b42e6c) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   87.69%   87.50%   -0.19%     
==========================================
  Files         437      458      +21     
  Lines       10807    11094     +287     
  Branches     1904     1863      -41     
==========================================
+ Hits         9477     9708     +231     
- Misses       1268     1324      +56     
  Partials       62       62              

Impacted Files	Coverage Δ
...ore/src/modules/ledger/services/IndyPoolService.ts	100.00% <100.00%> (ø)
packages/core/src/modules/dids/helpers.ts	90.47% <0.00%> (-4.77%)	⬇️
.../connections/handlers/ConnectionResponseHandler.ts	81.25% <0.00%> (-2.09%)	⬇️
...connections/handlers/DidExchangeResponseHandler.ts	80.95% <0.00%> (-1.27%)	⬇️
packages/core/src/agent/MessageSender.ts	84.61% <0.00%> (-1.18%)	⬇️
...les/credentials/protocol/v1/V1CredentialService.ts	87.19% <0.00%> (-1.13%)	⬇️
.../core/src/modules/credentials/CredentialsModule.ts	90.73% <0.00%> (-0.98%)	⬇️
...ckages/core/src/modules/dids/domain/DidDocument.ts	96.51% <0.00%> (-0.83%)	⬇️
...ckages/core/src/modules/routing/RecipientModule.ts	61.85% <0.00%> (-0.65%)	⬇️
...ntials/formats/indy/IndyCredentialFormatService.ts	88.01% <0.00%> (-0.56%)	⬇️
... and 59 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b42e6c...2b8ac4b. Read the comment docs.

[TheTreek]

How is this PR related to #804? Should we add a note to this code explaining why we're doing it in sequence instead of in parallel? Or is this change unrelated to that change?

The issue we were having is we tried to connect to all ledgers in parallel. This would cause us to reach the resource limit very quickly, so instead of doing it in parallel we do it in sequence so we don't use too many resources.

Will this also fix the issue with connectToIndyLedgersOnStartup?

Yes, this is the main goal of this PR.

[TimoGlastra]

The issue we were having is we tried to connect to all ledgers in parallel. This would cause us to reach the resource limit very quickly, so instead of doing it in parallel we do it in sequence so we don't use too many resources

Can we add a comment to the relevant code explaining this? I'm worried this will get lost and 'fixed' to parallel opening of pools in the future again.

[TimoGlastra]

Yes, this is the main goal of this PR

That is really great to hear!

[TheTreek]

The issue we were having is we tried to connect to all ledgers in parallel. This would cause us to reach the resource limit very quickly, so instead of doing it in parallel we do it in sequence so we don't use too many resources

Can we add a comment to the relevant code explaining this? I'm worried this will get lost and 'fixed' to parallel opening of pools in the future again.

Done!

[TimoGlastra]

Thansk @TheTreek, if you can update your branch I can merge!

[TimoGlastra]

Sorry it's out of date again :( Can you update again?