fix: close session early if no return route

packages/core/src/agent/MessageReceiver.ts

@@ -122,6 +122,9 @@ export class MessageReceiver {
       session.connection = connection ?? undefined
       messageContext.sessionId = session.id
       this.transportService.saveSession(session)
+    } else if (session) {
+      // No need to wait for session to stay open if we're not actually going to respond to the message.
+      await session.close()
     }
 
     await this.dispatcher.dispatch(messageContext)

packages/core/src/agent/TransportService.ts

@@ -67,4 +67,5 @@ export interface TransportSession {
   inboundMessage?: AgentMessage
   connection?: ConnectionRecord
   send(encryptedMessage: EncryptedMessage): Promise<void>
+  close(): Promise<void>
 }

packages/core/src/agent/__tests__/stubs.ts

@@ -17,4 +17,8 @@ export class DummyTransportSession implements TransportSession {
   public send(): Promise<void> {
     throw new Error('Method not implemented.')
   }
+
+  public close(): Promise<void> {
+    throw new Error('Method not implemented.')
+  }
 }

packages/node/src/transport/HttpInboundTransport.ts

@@ -75,6 +75,12 @@ export class HttpTransportSession implements TransportSession {
     this.res = res
   }
 
+  public async close(): Promise<void> {
+    if (!this.res.headersSent) {
+      this.res.status(200).end()
+    }
+  }
+
   public async send(encryptedMessage: EncryptedMessage): Promise<void> {
     if (this.res.headersSent) {
       throw new AriesFrameworkError(`${this.type} transport session has been closed.`)

packages/node/src/transport/WsInboundTransport.ts

@@ -88,4 +88,10 @@ export class WebSocketTransportSession implements TransportSession {
 
     this.socket.send(JSON.stringify(encryptedMessage))
   }
+
+  public async close(): Promise<void> {
+    if (this.socket.readyState === WebSocket.OPEN) {
+      this.socket.close()
+    }
+  }
 }

tests/transport/SubjectInboundTransport.ts

@@ -64,4 +64,10 @@ export class SubjectTransportSession implements TransportSession {
   public async send(encryptedMessage: EncryptedMessage): Promise<void> {
     this.replySubject.next({ message: encryptedMessage })
   }
+
+  public async close(): Promise<void> {
+    // FIXME: we should call complete, but this requires some changes already in this PR: https://github.com/hyperledger/aries-framework-javascript/pull/712
+    // We can then create a replySubject for each interaction, which mimics the the behavior of real transports better.
+    // this.replySubject.complete()
+  }
 }