feat: issue credential v2 #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NB Prasad Katkar <[email protected]>
refactor: resolve feedback for problem report (openwallet-foundation#584)
…mework-javascript into api20 merge with problem report
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
…r/aries-framework-javascript into hyperledger-feat/present-proof-v2
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
…-javascript into hyperledger-MAY3
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
approved these changes
May 4, 2022
There was a problem hiding this comment.
I've left a few more comments. I'm going to accept this PR and think it may be good to merge on the account that the outstanding comments just raised will be resolved as soon as possible.
I've opened this pr to address some small issues, also with the migration script: NB-MikeRichardson#27
In addition I have one more general comment:
- Offer credential interface is shared between offer credential and out of band offer. They should have separate interfaces as one requires a connectionId and the other explicitly doesn't need one.
packages/core/src/modules/credentials/__tests__/V2CredentialService.cred.test.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/formats/indy/IndyCredentialFormatService.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/formats/indy/IndyCredentialFormatService.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v2/messages/V2RequestCredentialMessage.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v2/messages/V2OfferCredentialMessage.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v2/handlers/V2OfferCredentialHandler.ts
Show resolved
Hide resolved
|
|
||
| expect(v2Proposal.message.formats.length).toBe(1) | ||
| expect(v2Proposal.message.formats[0].format).toEqual('hlindy/[email protected]') | ||
| // expect(v2Proposal.message.formats[1].format).toEqual('aries/[email protected]') |
There was a problem hiding this comment.
Suggested change
| // expect(v2Proposal.message.formats[1].format).toEqual('aries/[email protected]') |
Comment on lines
+29
to
+30
| public type = V1CredentialPreview.type | ||
| public static type = `https://didcomm.org/issue-credential/1.0/credential-preview` |
There was a problem hiding this comment.
Suggested change
| public type = V1CredentialPreview.type | |
| public static type = `https://didcomm.org/issue-credential/1.0/credential-preview` | |
| public readonly type = V1CredentialPreview.type | |
| public static readonly type = 'https://didcomm.org/issue-credential/1.0/credential-preview' |
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Fix/small icv2 fixe
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.