Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): requested predicates transform type #393

Conversation

TimoGlastra
Copy link
Contributor

Incorrect @Type transform was added to requested predicates, overriding @RecordTransformer.

@TimoGlastra TimoGlastra requested a review from a team as a code owner July 19, 2021 09:59
@berendsliedrecht berendsliedrecht enabled auto-merge (squash) July 19, 2021 10:01
@codecov-commenter
Copy link

Codecov Report

Merging #393 (cefbb4f) into main (34a6ff2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   86.53%   86.53%   -0.01%     
==========================================
  Files         236      236              
  Lines        4895     4894       -1     
  Branches      773      773              
==========================================
- Hits         4236     4235       -1     
  Misses        659      659              
Impacted Files Coverage Δ
.../src/modules/proofs/models/RequestedCredentials.ts 70.83% <100.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a6ff2...cefbb4f. Read the comment docs.

@berendsliedrecht berendsliedrecht merged commit 69684bc into openwallet-foundation:main Jul 19, 2021
@TimoGlastra TimoGlastra deleted the fix/requested-predicates branch October 28, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants