Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message to log #342

Merged

Conversation

TimoGlastra
Copy link
Contributor

Adds error message to error log.

@jakubkoci this is what you get when you don't include the error message specifically. I think we need to fix this in rn-indy-sdk. I'll try to look at it in the near future. For now this fix helps

image

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra force-pushed the fix/better-logging branch from 8ec25c6 to 2e0ae35 Compare July 2, 2021 11:33
@TimoGlastra
Copy link
Contributor Author

CI is failing because of error with indy-sdk publishing:

For anyone receiving an error like the following. We are aware of the issue and are working toward a resolution. I'll update the community when the issue has been resolved. Thank you for your patience.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #342 (2e0ae35) into main (93893b7) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         225      225           
  Lines        4093     4093           
  Branches      480      480           
=======================================
  Hits         3617     3617           
  Misses        476      476           
Impacted Files Coverage Δ
src/transport/HttpOutboundTransporter.ts 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93893b7...2e0ae35. Read the comment docs.

@TimoGlastra TimoGlastra enabled auto-merge (squash) July 3, 2021 11:49
@jakubkoci
Copy link
Contributor

Vau 😮 So it means that it prints empty error object like {} but if you call error.message it prints out an error message? 🤔 🤯

@TimoGlastra
Copy link
Contributor Author

Vau 😮 So it means that it prints empty error object like {} but if you call error.message it prints out an error message? 🤔 🤯

Exactly. It doesn't happen however in Node.JS

@TimoGlastra TimoGlastra merged commit a79e4f4 into openwallet-foundation:main Jul 9, 2021
@TimoGlastra TimoGlastra deleted the fix/better-logging branch July 9, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants