Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: websocket and fetch fix for browser #291

Conversation

berendsliedrecht
Copy link
Contributor

  • fix: fetch & websocket browser support

This add support for fetch and websocket in the browser environment. Typings had to be added to prevent errors in the respective outboundtransport

(Not sure if these typings are the correct way)

@berendsliedrecht berendsliedrecht requested a review from a team as a code owner May 21, 2021 10:33
@codecov-commenter
Copy link

Codecov Report

Merging #291 (5d908de) into main (799b6c8) will decrease coverage by 0.30%.
The diff coverage is 31.57%.

❗ Current head 5d908de differs from pull request most recent head 9d0e2d0. Consider uploading reports for the commit 9d0e2d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   88.47%   88.17%   -0.31%     
==========================================
  Files         217      217              
  Lines        3897     3906       +9     
  Branches      431      449      +18     
==========================================
- Hits         3448     3444       -4     
- Misses        449      462      +13     
Impacted Files Coverage Δ
src/utils/fetch.ts 47.05% <18.18%> (-52.95%) ⬇️
src/utils/ws.ts 62.50% <40.00%> (-37.50%) ⬇️
src/utils/environment.ts 75.00% <66.66%> (-25.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799b6c8...9d0e2d0. Read the comment docs.

@JamesKEbert JamesKEbert merged commit 84e570d into openwallet-foundation:main May 21, 2021
@berendsliedrecht berendsliedrecht deleted the fix/browser-environment-fetch branch August 31, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants