Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connection record type was BaseRecord #278

Merged
merged 3 commits into from
May 19, 2021

Conversation

TimoGlastra
Copy link
Contributor

No description provided.

@TimoGlastra TimoGlastra requested a review from a team as a code owner May 18, 2021 16:15
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 18, 2021 16:16
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #278 (6c64c9d) into main (a9c261e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         216      216           
  Lines        3897     3899    +2     
  Branches      438      438           
=======================================
+ Hits         3459     3461    +2     
  Misses        438      438           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
...modules/connections/repository/ConnectionRecord.ts 96.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c261e...6c64c9d. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 515395d into openwallet-foundation:main May 19, 2021
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra TimoGlastra deleted the small-fixes branch October 2, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants