-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add internal ws outbound transporter #267
feat: add internal ws outbound transporter #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have not tested as of yet.
670ea38
to
ff94883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing serious, mainly just questions. Overall seems good 👍
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 88.91% 88.84% -0.07%
==========================================
Files 203 205 +2
Lines 3734 3793 +59
Branches 424 432 +8
==========================================
+ Hits 3320 3370 +50
- Misses 414 423 +9
Continue to review full report at Codecov.
|
Signed-off-by: Timo Glastra <[email protected]>
0f36ecb
to
05bff39
Compare
add internal ws outbound transporter. Same as with HTTP. Next step is multi outbound transport support.