Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: didcomm module #2127

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Dec 5, 2024

Initial work on extracting DIDComm out of core. For the moment, all features are still present on core package, but moved into an internal "didcomm" module that eventually will be extracted along other DIDcomm dependent modules, such as proofs and credentials.

All DIDComm-related fields in AgentConfig were moved to DidCommModuleConfig. As such, some DIDComm-related Agent API methods such as the ones for transport and feature registration are now part of DIDComm module API (for example, agent.didcomm.features or agent.didcomm.registerOutboundTransport).

Lots of TODO:

  • Move all DIDComm related tests to their corresponding module
  • Remove Wallet interface dependency on DIDComm types, probably by removing pack and unpack methods and make them part of another kind of service (which can be also owned by the module that implements the wallet, like AskarModule)
  • Define a new way to register features and message handlers, since currently we do everything at module.register() and we need to ensure that DIDComm module and its objects have been registered
  • Create separate modules for didcomm, proofs, credentials and basic-messages

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 618b975

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@genaris genaris force-pushed the refactor/didcomm-module branch from d26f24e to ededb58 Compare December 19, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant