Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anoncreds Offer Attachment Type #2124

Merged
merged 3 commits into from
Dec 5, 2024
Merged

fix: Anoncreds Offer Attachment Type #2124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02b9e1d
try
gmulhearn Dec 5, 2024
855a61e
dummy commit
gmulhearn-anonyome Dec 5, 2024
58b26e4
dummy commit 2
gmulhearn-anonyome Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/anoncreds/src/formats/AnonCredsCredentialFormatService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ export class AnonCredsCredentialFormatService implements CredentialFormatService
// if the proposal has an attachment Id use that, otherwise the generated id of the formats object
const format = new CredentialFormatSpec({
attachmentId: attachmentId,
format: ANONCREDS_CREDENTIAL,
format: ANONCREDS_CREDENTIAL_OFFER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure this won't break previous versions, but we basically allow any of the identifiers for all messags, which is a bit weird but in this case helps a lot (but probably also why we didn't dettect this for so long)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense. i'm not sure if you guys had been interop testing with acapy, but they also have some minor issues with the attachment naming which i imagine would cause interop issues (see openwallet-foundation/acapy#3374). Hopefully after that we can have some good interop. this is specifically coming up as i've been testing out cheqd anoncreds (being introduced to acapy soon).

})

const offer = await anonCredsIssuerService.createCredentialOffer(agentContext, {
Expand Down
Loading