Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return valid schema in create schema method #193

Merged

Conversation

TimoGlastra
Copy link
Contributor

  • Add seqNo to returned schema after creating. This makes it usable out of the box, without making another ledger request. Taken from ACA-Py impl
  • getPublicDid() -> publicDid (as a getter method)
  • createCredentialSchema -> createSchema (more consistent with rest of codebase)
  • support_revocation -> supportRevocation

Fixes #146

@codecov-io
Copy link

Codecov Report

Merging #193 (5295041) into main (7b62574) will increase coverage by 0.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   89.35%   89.46%   +0.10%     
==========================================
  Files         153      153              
  Lines        3213     3208       -5     
  Branches      375      371       -4     
==========================================
- Hits         2871     2870       -1     
+ Misses        339      335       -4     
  Partials        3        3              
Impacted Files Coverage Δ
src/lib/modules/ledger/LedgerModule.ts 83.33% <75.00%> (-3.63%) ⬇️
src/lib/modules/ledger/LedgerService.ts 92.39% <87.50%> (+4.63%) ⬆️
src/lib/agent/Agent.ts 100.00% <100.00%> (ø)
src/lib/wallet/IndyWallet.ts 87.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b62574...5295041. Read the comment docs.

Copy link
Contributor

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, thanks @TimoGlastra 👍

@jakubkoci jakubkoci merged commit 4ca020b into openwallet-foundation:main Mar 8, 2021
@TimoGlastra TimoGlastra deleted the fix/schema-cred-def branch May 15, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use schema and credential definition returned from register function
3 participants