fix(openid4vc): several fixes and improvements #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
changed the title
Signed-off-by: Timo Glastra <[email protected]>
berendsliedrecht
approved these changes
Mar 18, 2024
packages/openid4vc/src/openid4vc-issuer/OpenId4VcIssuerService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-issuer/OpenId4VcIssuerServiceOptions.ts
Show resolved
Hide resolved
| type: openBadgeCredential.types, | ||
| issuer: new W3cIssuer({ id: issuerDid }), | ||
| credentialSubject: new W3cCredentialSubject({ id: holderDid }), | ||
| issuanceDate: w3cDate(Date.now()), |
There was a problem hiding this comment.
Not related to your PR, but looking at all the W3cXXX classes, it might be worth considering to make the W3cDate a class as well.
There was a problem hiding this comment.
Yeah maybe, or we can make it a date instance and do the transformation for the user
There was a problem hiding this comment.
I'm going to address this in a separate PR, as it will require quite some changes across the codebase 😊
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
issuanceMetadatato be provided during offer creation, to add some context to an issuance session. Can be used to already provide the credential data, store an user id so the data can be fetched at time of issuance, or other metadata.This was already supported, but just not exposed in the API.
Non breaking and can be released as 0.5.1