Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: w3c anoncreds #1791

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

auer-martin
Copy link
Contributor

fix: usage of wrong buffer implementation
fix: w3c anoncreds don't require a credential subject id to be present

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good 👍

Comment on lines 71 to 79
return new Promise<void>((resolve, reject) =>
socket.send(Buffer.from(JSON.stringify(payload)), (err) => {
// If the socket was created for this message and we don't have return routing enabled
// We can close the socket as it shouldn't return messages anymore
if (isNewSocket && !outboundPackage.responseRequested) {
socket.close()
}

if (err) return reject(err)
resolve()
})
)
// If the socket was created for this message and we don't have return routing enabled
// We can close the socket as it shouldn't return messages anymore
// make sure to use the socket in a manner that is compliant with the https://developer.mozilla.org/en-US/docs/Web/API/WebSocket
// (React Native) and https://github.com/websockets/ws (NodeJs)
socket.send(Buffer.from(JSON.stringify(payload)))
if (isNewSocket && !outboundPackage.responseRequested) {
socket.close()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already merged right?

@auer-martin auer-martin marked this pull request as ready for review March 12, 2024 12:04
@TimoGlastra TimoGlastra merged commit 913596c into openwallet-foundation:main Mar 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants