-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply new version of SD JWT package #1787
Changes from 22 commits
e877104
53a196b
111b52f
84f7a4e
5cafd53
0c050e9
62146f2
f0f7c92
87fd571
3495bcd
054dbd9
07e3c78
ba30c19
55bb6fb
190a38e
6500149
af95b18
d029bc5
3593597
42eb16e
a6f666a
e5254ea
31dda2a
31fd6ab
064da30
cdf2d3d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import type { JwkJson, Jwk } from '../../crypto' | ||
import type { HashName } from '../../utils' | ||
import type { DisclosureFrame, PresentationFrame } from '@sd-jwt/core' | ||
import type { DisclosureFrame, PresentationFrame } from '@sd-jwt/types' | ||
|
||
// TODO: extend with required claim names for input (e.g. vct) | ||
export type SdJwtVcPayload = Record<string, unknown> | ||
|
@@ -47,7 +47,7 @@ export type SdJwtVcPresentOptions<Payload extends SdJwtVcPayload = SdJwtVcPayloa | |
/** | ||
* Use true to disclose everything | ||
*/ | ||
presentationFrame: PresentationFrame<Payload> | true | ||
presentationFrame?: PresentationFrame<Payload> | ||
|
||
/** | ||
* This information is received out-of-band from the verifier. | ||
|
@@ -60,6 +60,10 @@ export type SdJwtVcPresentOptions<Payload extends SdJwtVcPayload = SdJwtVcPayloa | |
} | ||
} | ||
|
||
export type SdJwtVcGetPresentationKeysOptions = { | ||
compactSdJwtVc: string | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can be removed, as we don't need the getPresentableKeys method anymore right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes your correct. I'll remove all code related |
||
|
||
export type SdJwtVcVerifyOptions = { | ||
compactSdJwtVc: string | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thin true was removed, what is now the way to disclose everything vs nothing? Can you update the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it :)
FYI:
presentationFrame: undefined
presentationFrame: {} // empty object