feat: anoncreds w3c migration #1744

auer-martin · 2024-02-06T10:29:54Z

No description provided.

Signed-off-by: Martin Auer <[email protected]>

…ption

TimoGlastra

Lot of work @2mau!!! I've left quite some comments. Most of them are small housekeeping fixes, some require some more substantial refacotrs. I'm fine with possibly moving some improvements over to after this is merged and released, but especially the API surface can sometimes use some clenaup I think. The logic itself makes sense though and I think you made the right abstractions, nice job 👍

packages/anoncreds/src/AnonCredsModule.ts

packages/anoncreds/src/__tests__/AnonCredsModule.test.ts

packages/core/src/modules/vc/repository/W3cCredentialRepository.ts

packages/core/src/modules/vc/repository/W3cCredentialRecord.ts

packages/core/src/modules/dif-presentation-exchange/DifPresentationExchangeService.ts

...odules/proofs/formats/dif-presentation-exchange/DifPresentationExchangeProofFormatService.ts

packages/core/src/modules/vc/W3cCredentialService.ts

packages/core/src/modules/vc/W3cCredentialServiceOptions.ts

packages/anoncreds/src/anoncreds-rs/AnonCreds2023DataIntegrityService.ts

TimoGlastra · 2024-02-14T05:18:08Z

@2mau #1754 has just been merged. The tests were flaky and almost always failing. There are some changes however to e2e tests vs unit tests.

Could you make sure that all the tests you edited / added are following the new pattern:

e2e test: uses indy / cheqd / postgres / http / ws
unit test: other tests, can run without internet and external services

If a test is a e2e test it should end with .e2e.test.ts

An easy way to check is running the unit tests (yarn test:unit) without any of the docker-compose services running and any tests that fail because the service is not running should use .e2e.test.ts. Other way around is a bit harder, and is a bit more manual. Not sure how much of tests you wrote are using in memory anoncreds registry (preffered) vs indy/cheqd registry (for a few e2e tests)

TimoGlastra

Lots of good updates! I left some additional comments. Also some comments I left on previous review seemed unresolved but marked as resolved

packages/anoncreds/src/anoncreds-rs/AnonCredsDataIntegrityService.ts

packages/anoncreds/src/anoncreds-rs/AnonCredsRsHolderService.ts

packages/anoncreds/src/formats/LegacyIndyProofFormatService.ts

TimoGlastra · 2024-02-14T07:27:55Z

packages/anoncreds/src/formats/LegacyIndyProofFormatService.ts

-      if (!isUnqualifiedSchemaId(schemaId)) {
-        throw new CredoError(`${schemaId} is not a valid legacy indy schema id`)
-      }


This service should not support qualified ids. It's a legacy service (LegacyIndyProofFormatService), and was from before qualifieid identifiers existed.

TimoGlastra · 2024-02-14T07:29:11Z

packages/anoncreds/src/formats/DataIntegrityCredentialFormatService.ts

+    const missingBindingMethod =
+      binding_required && !binding_method?.anoncreds_link_secret && !binding_method?.didcomm_signed_attachment
+
+    const invalidDataModelVersions =
+      !data_model_versions_supported ||
+      data_model_versions_supported.length === 0 ||
+      data_model_versions_supported.some((v) => v !== '1.1' && v !== '2.0')
+
+    const invalidLinkSecretBindingMethod =
+      binding_method?.anoncreds_link_secret &&
+      (!binding_method.anoncreds_link_secret.cred_def_id ||
+        !binding_method.anoncreds_link_secret.key_correctness_proof ||
+        !binding_method.anoncreds_link_secret.nonce)
+
+    const invalidDidCommSignedAttachmentBindingMethod =
+      binding_method?.didcomm_signed_attachment &&
+      (!binding_method.didcomm_signed_attachment.algs_supported ||
+        !binding_method.didcomm_signed_attachment.did_methods_supported ||
+        !binding_method.didcomm_signed_attachment.nonce)
+
+    if (
+      missingBindingMethod ||
+      invalidDataModelVersions ||
+      invalidLinkSecretBindingMethod ||
+      invalidDidCommSignedAttachmentBindingMethod
+    ) {
+      throw new ProblemReportError('Invalid credential offer', {
+        problemCode: CredentialProblemReportReason.IssuanceAbandoned,
+      })
+    }
+  }


This is not resolved?

packages/anoncreds/src/anoncreds-rs/__tests__/AnonCredsRsServices.test.ts

packages/anoncreds/src/anoncreds-rs/AnonCredsRsHolderService.ts

Changes are addressed. Any open questions can be addressed in a follow-up PR

auer-martin added 30 commits January 18, 2024 09:54

feat: w3c migration + data integrity issuance protocol alpha

6f7193d

Signed-off-by: Martin Auer <[email protected]>

merge branch main

da663d6

Signed-off-by: Martin Auer <[email protected]>

fix: mainly issue regarding credential not being processed after rece…

3de7105

…ption

fix: lint issues

879b9dd

feat: add cryptosuite tag to the credential record

91da079

fix: TODOS in credential format service

32432a8

feat: presentation support

9fb93f5

fix: allow random presentation definition id string

c547754

feat: implement autorespond

ded0462

fix: todos

fd6fe4f

fix: remove presentation submission cryptosuite

86f8e6a

Merge branch 'main' into w3c-migration

1303a23

complete merge, and fix part's of the legacy identifier issues

d5c3866

fix: anoncreds-rs cryptosuite naming

866105a

Merge branch 'main' into w3c-migration

0c9c032

fix: rename anoncredsvc to anoncreds

76dc962

review changes

79d8eaf

fix: todos

cde35f8

fix: stuff

06ee6be

feat: also query legacy

9856e2f

fix: packed pex

378e4aa

update readme

1584dd8

feat: roll back demo

9acc6fa

fix: warn when using legacy

fb470e3

fix: add additional checks

29a1715

feat: update anoncreds-rs to 0.2.0-dev.11

443fe6a

feat: update pex to official release

8a278d0

fix: missing offerattachment format

218cf19

fix: offerattachment issues

1ea69de

fix: simplify linksecret handling for the anoncreds2023 cryptosuite

046b633

auer-martin added 4 commits February 6, 2024 09:35

Merge branch 'main' into w3c-migration

27c4671

fix: tests

9c2d574

fix: migration

cacc3c0

fix: credential validation issues

f456e1b

TimoGlastra previously requested changes Feb 6, 2024

View reviewed changes

TimoGlastra reviewed Feb 7, 2024

View reviewed changes

packages/anoncreds/src/anoncreds-rs/AnonCreds2023DataIntegrityService.ts Outdated Show resolved Hide resolved

auer-martin added 2 commits February 13, 2024 11:19

fix: incoroporate feedback

1c36fa2

fix: add cheqd test

9cefe8a

auer-martin force-pushed the w3c-migration branch from 091f9f4 to 9cefe8a Compare February 13, 2024 11:54

TimoGlastra added this to the 0.5 milestone Feb 14, 2024

TimoGlastra linked an issue Feb 14, 2024 that may be closed by this pull request

Always store qualified identifiers for AnonCreds objects, still supporting legacy indy identifiers in exchange #1391

Closed

5 tasks

auer-martin added 2 commits February 14, 2024 08:09

Merge branch 'main' into pr/2mau/1744

7b7b94c

Merge branch 'main' into pr/2mau/1744

88417f4

TimoGlastra reviewed Feb 14, 2024

View reviewed changes

auer-martin added 4 commits February 18, 2024 09:28

fix: incorporate feedback

26739a5

Merge branch 'main' into pr/2mau/1744

57adb0b

fix: merge issue

a74ffcb

fix: change import path

e4a26b6

auer-martin marked this pull request as ready for review February 19, 2024 14:45

auer-martin added 3 commits February 22, 2024 12:25

fix: update anoncreds to stable release

519e863

fix: AnonCredsClaimRecord value should only be string | number for now

7d24ab0

Merge branch 'main' into w3c-migration

45c4223

karimStekelenburg approved these changes Feb 23, 2024

View reviewed changes

auer-martin and others added 2 commits February 23, 2024 13:09

refactor: find and replace npm scope (openwallet-foundation#1712)

8d6e534

Merge branch 'main' into w3c-migration

ea1b036

karimStekelenburg merged commit d7c2bbb into openwallet-foundation:main Feb 23, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: anoncreds w3c migration #1744

feat: anoncreds w3c migration #1744

auer-martin commented Feb 6, 2024

TimoGlastra left a comment

TimoGlastra commented Feb 14, 2024

TimoGlastra left a comment

TimoGlastra Feb 14, 2024

TimoGlastra Feb 14, 2024

feat: anoncreds w3c migration #1744

feat: anoncreds w3c migration #1744

Conversation

auer-martin commented Feb 6, 2024

TimoGlastra left a comment

Choose a reason for hiding this comment

TimoGlastra commented Feb 14, 2024

TimoGlastra left a comment

Choose a reason for hiding this comment

TimoGlastra Feb 14, 2024

Choose a reason for hiding this comment

TimoGlastra Feb 14, 2024

Choose a reason for hiding this comment