Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anoncreds): only store the revocation registry definition when the state is finished #1735

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix(anoncreds): only store the revocation registry definition when the state is finished #1735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/anoncreds/src/AnonCredsApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,10 @@ export class AnonCredsApi {
options: options.options,
})

await this.storeRevocationRegistryDefinitionRecord(result, revocationRegistryDefinitionPrivate)
// To avoid having unregistered revocation registry definitions in the wallet, the revocation registry definition itself are stored only when the revocation registry definition status is finished, meaning that the revocation registry definition has been successfully registered.
if (result.revocationRegistryDefinitionState.state === 'finished') {
await this.storeRevocationRegistryDefinitionRecord(result, revocationRegistryDefinitionPrivate)
}

return {
...result,
Expand Down
Loading