Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presentation-exchange): added PresentationExchangeService #1672

Merged
merged 3 commits into from
Dec 19, 2023
Merged

feat(presentation-exchange): added PresentationExchangeService #1672

merged 3 commits into from
Dec 19, 2023

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented Dec 13, 2023 •
edited
Loading

TimoGlastra
TimoGlastra reviewed Dec 14, 2023
View reviewed changes
packages/core/src/modules/proofs/index.ts Outdated
@@ -12,3 +12,6 @@ export * from './ProofsApiOptions'
// Module
export * from './ProofsModule'
export * from './ProofsModuleConfig'

// Services
export * from './services'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we create a separate module for this already in AFJ, as the current proofs module is mainly focused on didcomm, and I think it's good to keep that separated from functionality that is not related to didcomm.

Copy link
Contributor Author

@berendsliedrecht berendsliedrecht Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, happy to do it as a separate package already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that just be a module without a public API then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a new module now that just contains the service, no public API.

@berendsliedrecht berendsliedrecht force-pushed the pex-service branch 2 times, most recently from 2d6e518 to 47577cf Compare December 14, 2023 11:09
@berendsliedrecht berendsliedrecht marked this pull request as ready for review December 14, 2023 11:11
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner December 14, 2023 11:11
@berendsliedrecht berendsliedrecht changed the title feat(proofs): added PresentationExchangeService feat(presentation-exchange): added PresentationExchangeService Dec 15, 2023
TimoGlastra
TimoGlastra reviewed Dec 18, 2023
View reviewed changes
packages/core/src/modules/presentation-exchange/PresentationExchangeModule.ts
/**
* @public
*/
export class PresentationExchangeModule implements Module {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add the experimental warning to this module as well? As we'll need to make several changes to this over the coming weeks

packages/core/src/modules/presentation-exchange/PresentationExchangeService.ts
Comment on lines +93 to +94
// For now we retrieve ALL credentials, as we did the same for V1 with JWT credentials. We probably need
// to find some way to do initial filtering, hopefully if there's a filter on the `type` field or something.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to look at this in the near future. This will cause issues for sure

packages/presentation-exchange/src/index.ts Outdated
@@ -0,0 +1,4 @@
export * from './PresentationExchangeError'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there now seems to be logic in core, as well as in a separate presentation exchange package

@berendsliedrecht
feat(pex): created core PEX module
f4420c0 
Signed-off-by: Berend Sliedrecht <[email protected]>
@TimoGlastra TimoGlastra merged commit 50db5c7 into openwallet-foundation:main Dec 19, 2023
7 checks passed
@berendsliedrecht berendsliedrecht deleted the pex-service branch December 19, 2023 12:50
genaris pushed a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024
@berendsliedrecht @genaris
feat(presentation-exchange): added PresentationExchangeService (openw…
4c17d8d 
…allet-foundation#1672)

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
genaris added a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024
@genaris
fix: only remove session if it's not the new one
5afcd33 
Signed-off-by: Ariel Gentile <[email protected]>

feat: deliver messages individually, not fetching from the queue every time

Signed-off-by: Ariel Gentile <[email protected]>

chore: revert to free runners (openwallet-foundation#1662)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: create settings.yml (openwallet-foundation#1663)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: fix ci and add note to readme (openwallet-foundation#1669)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

docs: update active maintainers (openwallet-foundation#1664)

Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: did:peer:2 and did:peer:4 support in DID Exchange (openwallet-foundation#1550)

Signed-off-by: Ariel Gentile <[email protected]>

feat(presentation-exchange): added PresentationExchangeService (openwallet-foundation#1672)

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: removed jan as maintainer (openwallet-foundation#1678)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

ci: change secret (openwallet-foundation#1679)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: add meta to rxjs timeout errors (openwallet-foundation#1683)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump ws and @types/ws (openwallet-foundation#1686)

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (openwallet-foundation#1694)

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: update shared components libraries (openwallet-foundation#1691)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix: properly print key class (openwallet-foundation#1684)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat(present-proof): add support for aries RFC 510 (openwallet-foundation#1676)

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix(present-proof): isolated tests (openwallet-foundation#1696)

Signed-off-by: Ariel Gentile <[email protected]>

feat(indy-vdr): register revocation registry definitions and status list (openwallet-foundation#1693)

Signed-off-by: Ariel Gentile <[email protected]>

chore: rename to credo-ts (openwallet-foundation#1703)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

ci: fix git checkout path and update setup-node (openwallet-foundation#1709)

Signed-off-by: Ariel Gentile <[email protected]>

fix: remove check for DifPresentationExchangeService dependency (openwallet-foundation#1702)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

docs: update zoom meeting link (openwallet-foundation#1706)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

refactor(oob)!: make label optional (openwallet-foundation#1680)

Signed-off-by: Timo Glastra <[email protected]>
Co-authored-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: support short legacy connectionless invitations (openwallet-foundation#1705)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat(dids)!: did caching (openwallet-foundation#1710)

feat: did caching

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix: jsonld document loader node 18 (openwallet-foundation#1454)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (openwallet-foundation#1656)

build(deps): bump amannn/action-semantic-pull-request

Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases)
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md)
- [Commits](amannn/action-semantic-pull-request@v5.3.0...v5.4.0)

---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: did rotate (openwallet-foundation#1699)

Signed-off-by: Ariel Gentile <[email protected]>

refactor: pickup protocol method names

Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendsliedrecht @TimoGlastra