-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sped up lookup for revocation registries #1605
Merged
TimoGlastra
merged 3 commits into
openwallet-foundation:main
from
wadeking98:feat-rev-reg-lookup-speedup
Oct 12, 2023
Merged
feat: sped up lookup for revocation registries #1605
TimoGlastra
merged 3 commits into
openwallet-foundation:main
from
wadeking98:feat-rev-reg-lookup-speedup
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-rev-reg-lookup-speedup
branch
from
October 10, 2023 21:54
ea41b59
to
9cf1318
Compare
Codecov Report
@@ Coverage Diff @@
## main #1605 +/- ##
===========================================
+ Coverage 62.85% 85.75% +22.89%
===========================================
Files 779 951 +172
Lines 18074 22863 +4789
Branches 3121 4018 +897
===========================================
+ Hits 11361 19606 +8245
+ Misses 6171 3073 -3098
+ Partials 542 184 -358
|
TimoGlastra
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Some small code formatting suggestion
wadeking98
force-pushed
the
feat-rev-reg-lookup-speedup
branch
from
October 11, 2023 20:24
3c64bc8
to
14e573c
Compare
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-rev-reg-lookup-speedup
branch
from
October 11, 2023 20:25
14e573c
to
c347bfa
Compare
TimoGlastra
approved these changes
Oct 12, 2023
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Oct 16, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Oct 24, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Oct 26, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Oct 26, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Martin Auer <[email protected]>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Dec 4, 2023
…#1605) Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when fetching multiple revocation registries, afj would wait for the response from the first request before sending off the second request. I added functionality to send off all requests at once and then wait for all responses. This makes the code more async and faster