Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sped up lookup for revocation registries #1605

Merged

Conversation

wadeking98
Copy link
Contributor

Previously when fetching multiple revocation registries, afj would wait for the response from the first request before sending off the second request. I added functionality to send off all requests at once and then wait for all responses. This makes the code more async and faster

@wadeking98 wadeking98 requested a review from a team as a code owner October 10, 2023 21:51
@wadeking98 wadeking98 force-pushed the feat-rev-reg-lookup-speedup branch from ea41b59 to 9cf1318 Compare October 10, 2023 21:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #1605 (2fc47c3) into main (a1942f8) will increase coverage by 22.89%.
The diff coverage is 16.00%.

@@             Coverage Diff             @@
##             main    #1605       +/-   ##
===========================================
+ Coverage   62.85%   85.75%   +22.89%     
===========================================
  Files         779      951      +172     
  Lines       18074    22863     +4789     
  Branches     3121     4018      +897     
===========================================
+ Hits        11361    19606     +8245     
+ Misses       6171     3073     -3098     
+ Partials      542      184      -358     
Files Coverage Δ
...ges/anoncreds/src/utils/getRevocationRegistries.ts 50.00% <16.00%> (+40.62%) ⬆️

... and 475 files with indirect coverage changes

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Some small code formatting suggestion

packages/anoncreds/src/utils/getRevocationRegistries.ts Outdated Show resolved Hide resolved
packages/anoncreds/src/utils/getRevocationRegistries.ts Outdated Show resolved Hide resolved
@wadeking98 wadeking98 force-pushed the feat-rev-reg-lookup-speedup branch from 3c64bc8 to 14e573c Compare October 11, 2023 20:24
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 force-pushed the feat-rev-reg-lookup-speedup branch from 14e573c to c347bfa Compare October 11, 2023 20:25
@TimoGlastra TimoGlastra merged commit 32ef8c5 into openwallet-foundation:main Oct 12, 2023
7 checks passed
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 16, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 24, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 26, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 26, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
genaris pushed a commit to genaris/credo-ts that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants