Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save AnonCredsCredentialRecord createdAt #1603

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Oct 9, 2023

For some unfortunate reason, we are not saving createdAt at AnonCredsCredentialRecord creation. This is useful to do things like sorting credentials by their issuance date (something available with W3C Credential Reacords)

@genaris genaris requested a review from a team as a code owner October 9, 2023 02:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #1603 (df182a5) into main (a0458fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1603   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files         951      951           
  Lines       22854    22855    +1     
  Branches     4017     4018    +1     
=======================================
+ Hits        19601    19602    +1     
  Misses       3069     3069           
  Partials      184      184           
Files Coverage Δ
...ncreds/src/repository/AnonCredsCredentialRecord.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@berendsliedrecht berendsliedrecht merged commit a1942f8 into openwallet-foundation:main Oct 10, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 16, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 24, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 26, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 26, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
genaris added a commit to genaris/credo-ts that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants