fix(askar): throw error if imported wallet exists #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
Closed
TimoGlastra
approved these changes
Sep 28, 2023
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
…ion#1593) Signed-off-by: Ariel Gentile <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
…ion#1593) Signed-off-by: Ariel Gentile <[email protected]> Signed-off-by: Martin Auer <[email protected]>
genaris
added a commit
to genaris/credo-ts
that referenced
this pull request
Dec 4, 2023
…ion#1593) Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1587, when importing a wallet that already exists, in Android and Node.js environments AFJ is overwriting it, while in iOS is throwing an error.
In this PR we make the behaviour consistent across platforms and always throw a
WalletImportPathExistsError.Here we also handle the case that helped to discover this error: when a wrong key was entered for an import, further attempts would fail because the wallet DB file has been already copied. So in case of any import error (other than path already existent), we now delete it to return file system to previous state.