Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v0.4.1 #1548

Merged
merged 1 commit into from
Aug 28, 2023
Merged

chore(release): v0.4.1 #1548

merged 1 commit into from
Aug 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Release version 0.4.1

@github-actions github-actions bot requested a review from a team as a code owner August 18, 2023 11:30
@genaris
Copy link
Contributor

genaris commented Aug 18, 2023

@TimoGlastra in yesterday's meeting we were thinking on adding #1427 to this minor release before it becomes a breaking change (as the new anoncreds-rs will drop support to node 16).

What do you think about that? From my side I'm good in either way, as long as we move quick on 0.5.0 release and all its dependencies (i.e. new shared component releases) 😄

@TimoGlastra
Copy link
Contributor

I'm fine with both. I'm also fine to do a 0.5.0 release right after 0.4.1 where we drop support for Node 16 all together. This would make the 0.5.x upgrade really straightforward if you're already on Node 18

So up to you :-)

@genaris
Copy link
Contributor

genaris commented Aug 18, 2023

I'm fine with both. I'm also fine to do a 0.5.0 release right after 0.4.1 where we drop support for Node 16 all together. This would make the 0.5.x upgrade really straightforward if you're already on Node 18

So up to you :-)

Oh no so much pressure on me! 😅

I think we can keep this minor release as it is right now, and merge the revocable issuance support afterwards for a 0.4.2-alpha / 0.5.0-alpha so we give to it some time before putting into an 'official' release.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #1548 (881a75f) into main (93276de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         950      950           
  Lines       22744    22744           
  Branches     3978     3978           
=======================================
  Hits        19500    19500           
  Misses       3059     3059           
  Partials      185      185           

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@TimoGlastra TimoGlastra added the ci-test Trigger tests on a pull request label Aug 28, 2023
@TimoGlastra TimoGlastra enabled auto-merge (squash) August 28, 2023 20:25
@TimoGlastra TimoGlastra merged commit c0d9304 into main Aug 28, 2023
@TimoGlastra TimoGlastra deleted the lerna-release branch August 28, 2023 20:43
genaris pushed a commit to genaris/credo-ts that referenced this pull request Sep 22, 2023
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ariel Gentile <[email protected]>
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Martin Auer <[email protected]>
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Martin Auer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-test Trigger tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants