Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cheqd): make cosmos payer seed optional #1547

Conversation

TimoGlastra
Copy link
Contributor

Makes the cosmos payer seed optional, as you can also used it as a holder without payer seed.

@TimoGlastra TimoGlastra requested a review from a team as a code owner August 18, 2023 10:45
@TimoGlastra TimoGlastra changed the title fix: make cosmos payer seed optional fix(cheqd): make cosmos payer seed optional Aug 18, 2023
@TimoGlastra
Copy link
Contributor Author

@berendsliedrecht can you re-review. I also added an overwrite of the Buffer global. Not sure though if we should do this?

@berendsliedrecht
Copy link
Contributor

@berendsliedrecht can you re-review. I also added an overwrite of the Buffer global. Not sure though if we should do this?

Ideally only for the cheqd specific dependencies. Since you would do this in your app anyways to make it work, I think it is okay.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #1547 (f86deaa) into main (8f2d593) will increase coverage by 1.39%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
+ Coverage   84.34%   85.73%   +1.39%     
==========================================
  Files         950      950              
  Lines       22743    22744       +1     
  Branches     3977     3978       +1     
==========================================
+ Hits        19183    19500     +317     
+ Misses       3337     3059     -278     
+ Partials      223      185      -38     
Files Changed Coverage Δ
packages/cheqd/src/CheqdModuleConfig.ts 100.00% <ø> (ø)
packages/cheqd/src/ledger/CheqdLedgerService.ts 80.85% <33.33%> (ø)
packages/cheqd/src/CheqdModule.ts 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

@TimoGlastra TimoGlastra merged commit 9377378 into openwallet-foundation:main Aug 18, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants