Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Registered Connection Problem report message handler #1462

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: Registered Connection Problem report message handler #1462

merged 1 commit into from
May 24, 2023

Conversation

dheerajbudhiraja
Copy link
Contributor

No description provided.

@dheerajbudhiraja dheerajbudhiraja requested a review from a team as a code owner May 19, 2023 08:25
@dheerajbudhiraja dheerajbudhiraja mentioned this pull request May 19, 2023
Open
@dheerajbudhiraja dheerajbudhiraja changed the title Registered Connection Problem report message handler fix: Registered Connection Problem report message handler May 19, 2023
genaris
genaris previously requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dheerajbudhiraja !
It seems that there are a few lint/prettier errors:

/home/runner/work/aries-framework-javascript/aries-framework-javascript/packages/core/src/modules/connections/ConnectionsApi.ts
Error: 30:33 error Insert , prettier/prettier
Error: 425:110 error Delete ; prettier/prettier

/home/runner/work/aries-framework-javascript/aries-framework-javascript/packages/core/src/modules/connections/handlers/index.ts
Error: 9:15 error Replace "./ConnectionProblemReportHandler" with './ConnectionProblemReportHandler' prettier/prettier

/home/runner/work/aries-framework-javascript/aries-framework-javascript/packages/core/src/modules/connections/services/ConnectionService.ts
Error: 437:56 error Replace connectionRecord,DidExchangeState.Abandoned); with ·connectionRecord,·DidExchangeState.Abandoned) prettier/prettier
Error: 438:1 error Delete ···· prettier/prettier

Could you fix them? Afterwards, you can run yarn lint, yarn check-format and yarn check-types to make sure everything is in place.

dheerajbudhiraja
dheerajbudhiraja commented May 20, 2023
View reviewed changes
Copy link
Contributor Author

@dheerajbudhiraja dheerajbudhiraja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested prettier and lint changes done. @genaris

@dheerajbudhiraja dheerajbudhiraja requested a review from genaris May 22, 2023 07:38
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 24, 2023 20:23
@TimoGlastra TimoGlastra merged commit d2d8ee0 into openwallet-foundation:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

@genaris genaris Awaiting requested review from genaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dheerajbudhiraja @genaris @TimoGlastra