Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set updateAt on records when updating a record #1272

Merged
merged 13 commits into from
Feb 10, 2023
Merged

fix: set updateAt on records when updating a record #1272

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a7f7e44
updating updatedAt when a record is saved or updated
KolbyRKunz Dec 19, 2022
28a1230
updating test records
KolbyRKunz Dec 19, 2022
e47be2c
Merged Main
KolbyRKunz Jan 27, 2023
20e92e9
Merge branch 'main' into feat/messageSorting
KolbyRKunz Jan 30, 2023
4ccf262
Merge branch 'main' into feat/messageSorting
KolbyRKunz Feb 6, 2023
17cd492
updated tests to check the updatedAt time is set properly
KolbyRKunz Feb 7, 2023
1ad765e
Merge branch 'main' into feat/messageSorting
KolbyRKunz Feb 9, 2023
18402b4
checked updated time against time at start of the tests
KolbyRKunz Feb 9, 2023
062f596
updated askar to be inline with changes
KolbyRKunz Feb 9, 2023
77dfb7e
Merge branch 'main' into feat/messageSorting
KolbyRKunz Feb 10, 2023
f6c2583
Merge branch 'main' into feat/messageSorting
KolbyRKunz Feb 10, 2023
0c3a5aa
fix: update test snapshots
genaris Feb 10, 2023
02605b1
Merge pull request #6 from genaris/fix/update-snapshots
KolbyRKunz Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/src/storage/IndyStorageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ export class IndyStorageService<T extends BaseRecord<any, any, any>> implements
public async save(agentContext: AgentContext, record: T) {
assertIndyWallet(agentContext.wallet)

record.updatedAt = new Date()

const value = JsonTransformer.serialize(record)
const tags = this.transformFromRecordTagValues(record.getTags()) as Record<string, string>

Expand All @@ -157,6 +159,8 @@ export class IndyStorageService<T extends BaseRecord<any, any, any>> implements
public async update(agentContext: AgentContext, record: T): Promise<void> {
assertIndyWallet(agentContext.wallet)

record.updatedAt = new Date()

const value = JsonTransformer.serialize(record)
const tags = this.transformFromRecordTagValues(record.getTags()) as Record<string, string>

Expand Down
2 changes: 2 additions & 0 deletions tests/InMemoryStorageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class InMemoryStorageService<T extends BaseRecord = BaseRecord> implement

/** @inheritDoc */
public async save(agentContext: AgentContext, record: T) {
record.updatedAt = new Date()
const value = JsonTransformer.toJSON(record)

if (this.records[record.id]) {
Expand All @@ -51,6 +52,7 @@ export class InMemoryStorageService<T extends BaseRecord = BaseRecord> implement

/** @inheritDoc */
public async update(agentContext: AgentContext, record: T): Promise<void> {
record.updatedAt = new Date()
const value = JsonTransformer.toJSON(record)
delete value._tags

Expand Down