feat: support short legacy connectionless invitations #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
genaris
approved these changes
Jan 29, 2024
| const invitation = new OutOfBandInvitation({ | ||
| // The label is currently required by the OutOfBandInvitation class, but not according to the specification. | ||
| // FIXME: In 0.5.0 we will make this optional: https://github.com/hyperledger/aries-framework-javascript/issues/1524 | ||
| label: '', |
There was a problem hiding this comment.
If we can merge the optional label PR first, we can simply avoid using this empty label. See #1680 (comment)
There was a problem hiding this comment.
I'll update once #1680 is merged
…ned-legacy-connectionless-invitations
Signed-off-by: Timo Glastra <[email protected]>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Jan 29, 2024
…ndation#1705) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>
genaris
added a commit
to genaris/credo-ts
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Ariel Gentile <[email protected]> feat: deliver messages individually, not fetching from the queue every time Signed-off-by: Ariel Gentile <[email protected]> chore: revert to free runners (openwallet-foundation#1662) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: create settings.yml (openwallet-foundation#1663) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: fix ci and add note to readme (openwallet-foundation#1669) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> docs: update active maintainers (openwallet-foundation#1664) Signed-off-by: Karim Stekelenburg <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: did:peer:2 and did:peer:4 support in DID Exchange (openwallet-foundation#1550) Signed-off-by: Ariel Gentile <[email protected]> feat(presentation-exchange): added PresentationExchangeService (openwallet-foundation#1672) Signed-off-by: Berend Sliedrecht <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: removed jan as maintainer (openwallet-foundation#1678) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> ci: change secret (openwallet-foundation#1679) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: add meta to rxjs timeout errors (openwallet-foundation#1683) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump ws and @types/ws (openwallet-foundation#1686) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (openwallet-foundation#1694) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> chore: update shared components libraries (openwallet-foundation#1691) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix: properly print key class (openwallet-foundation#1684) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat(present-proof): add support for aries RFC 510 (openwallet-foundation#1676) Signed-off-by: Berend Sliedrecht <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix(present-proof): isolated tests (openwallet-foundation#1696) Signed-off-by: Ariel Gentile <[email protected]> feat(indy-vdr): register revocation registry definitions and status list (openwallet-foundation#1693) Signed-off-by: Ariel Gentile <[email protected]> chore: rename to credo-ts (openwallet-foundation#1703) Signed-off-by: Ry Jones <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> ci: fix git checkout path and update setup-node (openwallet-foundation#1709) Signed-off-by: Ariel Gentile <[email protected]> fix: remove check for DifPresentationExchangeService dependency (openwallet-foundation#1702) Signed-off-by: Sai Ranjit Tummalapalli <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> docs: update zoom meeting link (openwallet-foundation#1706) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> refactor(oob)!: make label optional (openwallet-foundation#1680) Signed-off-by: Timo Glastra <[email protected]> Co-authored-by: Ariel Gentile <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: support short legacy connectionless invitations (openwallet-foundation#1705) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat(dids)!: did caching (openwallet-foundation#1710) feat: did caching Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> fix: jsonld document loader node 18 (openwallet-foundation#1454) Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> build(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (openwallet-foundation#1656) build(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@v5.3.0...v5.4.0) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Ariel Gentile <[email protected]> feat: did rotate (openwallet-foundation#1699) Signed-off-by: Ariel Gentile <[email protected]> refactor: pickup protocol method names Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a legacy connectionless invitation is hosted and shared as a short url. E.g. in the case of https://github.com/bcgov/vc-authn-oidc