Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jsonld document loader node 18 #1454

Conversation

TimoGlastra
Copy link
Contributor

Fixes the JSON-LD document loader in node 18. For now the node document loader is copied, but if digitalcredentials/jsonld.js#2 is merged and released we can remove the custom implementation in AFJ.

@TimoGlastra TimoGlastra requested a review from a team as a code owner May 11, 2023 09:53
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 22, 2023 12:53
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #1454 (b2c1ae6) into main (0f528ba) will decrease coverage by 17.14%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##             main    #1454       +/-   ##
===========================================
- Coverage   79.81%   62.68%   -17.14%     
===========================================
  Files         917      778      -139     
  Lines       22150    17976     -4174     
  Branches     3888     3087      -801     
===========================================
- Hits        17679    11268     -6411     
- Misses       4160     6164     +2004     
- Partials      311      544      +233     
Files Changed Coverage Δ
...c/data-integrity/libraries/nativeDocumentLoader.ts 33.33% <0.00%> (ø)
...es/vc/data-integrity/W3cJsonLdCredentialService.ts 52.50% <100.00%> (-27.85%) ⬇️

... and 387 files with indirect coverage changes

@TimoGlastra
Copy link
Contributor Author

Discussed on AFJ WG Call @TimoGlastra to look into this PR

@genaris genaris disabled auto-merge August 23, 2023 10:26
@genaris
Copy link
Contributor

genaris commented Aug 23, 2023

As digitalcredentials/jsonld.js#2 has been merged and I think incorporated into the new release of @digitalcredentials/jsonld, now we can remove the custom implementation, right?

@TimoGlastra
Copy link
Contributor Author

Yes!

@TimoGlastra
Copy link
Contributor Author

PR revived. Let's hope it we can get it merged now

@TimoGlastra TimoGlastra enabled auto-merge (squash) January 29, 2024 14:58
@TimoGlastra TimoGlastra merged commit 3656d49 into openwallet-foundation:main Jan 29, 2024
7 checks passed
genaris pushed a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024
genaris added a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024
Signed-off-by: Ariel Gentile <[email protected]>

feat: deliver messages individually, not fetching from the queue every time

Signed-off-by: Ariel Gentile <[email protected]>

chore: revert to free runners (openwallet-foundation#1662)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: create settings.yml (openwallet-foundation#1663)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: fix ci and add note to readme (openwallet-foundation#1669)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

docs: update active maintainers (openwallet-foundation#1664)

Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: did:peer:2 and did:peer:4 support in DID Exchange (openwallet-foundation#1550)

Signed-off-by: Ariel Gentile <[email protected]>

feat(presentation-exchange): added PresentationExchangeService (openwallet-foundation#1672)

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: removed jan as maintainer (openwallet-foundation#1678)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

ci: change secret (openwallet-foundation#1679)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: add meta to rxjs timeout errors (openwallet-foundation#1683)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump ws and @types/ws (openwallet-foundation#1686)

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (openwallet-foundation#1694)

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

chore: update shared components libraries (openwallet-foundation#1691)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix: properly print key class (openwallet-foundation#1684)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat(present-proof): add support for aries RFC 510 (openwallet-foundation#1676)

Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix(present-proof): isolated tests (openwallet-foundation#1696)

Signed-off-by: Ariel Gentile <[email protected]>

feat(indy-vdr): register revocation registry definitions and status list (openwallet-foundation#1693)

Signed-off-by: Ariel Gentile <[email protected]>

chore: rename to credo-ts (openwallet-foundation#1703)

Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

ci: fix git checkout path and update setup-node (openwallet-foundation#1709)

Signed-off-by: Ariel Gentile <[email protected]>

fix: remove check for DifPresentationExchangeService dependency (openwallet-foundation#1702)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

docs: update zoom meeting link (openwallet-foundation#1706)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

refactor(oob)!: make label optional (openwallet-foundation#1680)

Signed-off-by: Timo Glastra <[email protected]>
Co-authored-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: support short legacy connectionless invitations (openwallet-foundation#1705)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat(dids)!: did caching (openwallet-foundation#1710)

feat: did caching

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

fix: jsonld document loader node 18 (openwallet-foundation#1454)

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

build(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (openwallet-foundation#1656)

build(deps): bump amannn/action-semantic-pull-request

Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases)
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md)
- [Commits](amannn/action-semantic-pull-request@v5.3.0...v5.4.0)

---
updated-dependencies:
- dependency-name: amannn/action-semantic-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>

feat: did rotate (openwallet-foundation#1699)

Signed-off-by: Ariel Gentile <[email protected]>

refactor: pickup protocol method names

Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants