fix(anoncreds): allow for zero idx to be used for revocation (#1742)

Signed-off-by: Berend Sliedrecht <[email protected]>
openwallet-foundation · Feb 6, 2024 · a1b9901 · a1b9901
1 parent 0bec03c
commit a1b9901
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/anoncreds/src/formats/AnonCredsCredentialFormatService.ts b/packages/anoncreds/src/formats/AnonCredsCredentialFormatService.ts
@@ -613,7 +613,7 @@ export class AnonCredsCredentialFormatService implements CredentialFormatService
     ).credentialDefinition.value
 
     if (credentialDefinition.revocation) {
-      if (!revocationRegistryDefinitionId || !revocationRegistryIndex) {
+      if (!revocationRegistryDefinitionId || revocationRegistryIndex === undefined) {
         throw new CredoError(
           'AnonCreds revocable credentials require revocationRegistryDefinitionId and revocationRegistryIndex'
         )

diff --git a/packages/anoncreds/src/formats/AnonCredsProofFormatService.ts b/packages/anoncreds/src/formats/AnonCredsProofFormatService.ts
@@ -519,7 +519,7 @@ export class AnonCredsProofFormatService implements ProofFormatService<AnonCreds
 
     // If revocation interval is not present or the credential is not revocable then we
     // don't need to fetch the revocation status
-    if (!requestNonRevoked || !credentialRevocationId || !revocationRegistryId) {
+    if (!requestNonRevoked || credentialRevocationId === null || !revocationRegistryId) {
       return { isRevoked: undefined, timestamp: undefined }
     }
 

diff --git a/packages/anoncreds/src/formats/LegacyIndyProofFormatService.ts b/packages/anoncreds/src/formats/LegacyIndyProofFormatService.ts
@@ -531,7 +531,7 @@ export class LegacyIndyProofFormatService implements ProofFormatService<LegacyIn
 
     // If revocation interval is not present or the credential is not revocable then we
     // don't need to fetch the revocation status
-    if (!requestNonRevoked || !credentialRevocationId || !revocationRegistryId) {
+    if (!requestNonRevoked || credentialRevocationId === null || !revocationRegistryId) {
       return { isRevoked: undefined, timestamp: undefined }
     }