fix(present-proof): do not take credentials as an input

Signed-off-by: Berend Sliedrecht <[email protected]>
openwallet-foundation · Dec 21, 2023 · 5551267 · 5551267
1 parent 27fb71a
commit 5551267
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 19 deletions.
diff --git a/.../core/src/modules/proofs/formats/presentation-exchange/PresentationExchangeProofFormat.ts b/.../core/src/modules/proofs/formats/presentation-exchange/PresentationExchangeProofFormat.ts
@@ -19,9 +19,7 @@ export interface PresentationExchangeProofFormat extends ProofFormat {
       presentationDefinition: PresentationDefinition
     }
 
-    acceptRequest: {
-      credentials: Array<W3cCredentialRecord>
-    }
+    acceptRequest: never
 
     getCredentialsForRequest: {
       input: never

diff --git a/...rc/modules/proofs/formats/presentation-exchange/PresentationExchangeProofFormatService.ts b/...rc/modules/proofs/formats/presentation-exchange/PresentationExchangeProofFormatService.ts
@@ -143,14 +143,8 @@ export class PresentationExchangeProofFormatService implements ProofFormatServic
 
   public async acceptRequest(
     agentContext: AgentContext,
-    { attachmentId, requestAttachment, proofFormats }: ProofFormatAcceptRequestOptions<PresentationExchangeProofFormat>
+    { attachmentId, requestAttachment }: ProofFormatAcceptRequestOptions<PresentationExchangeProofFormat>
   ): Promise<ProofFormatCreateReturn> {
-    const presentationExchangeFormat = proofFormats?.presentationExchange
-
-    if (!presentationExchangeFormat) {
-      throw Error('Missing presentation exchange format in create request attachment format')
-    }
-
     const ps = this.presentationExchangeService(agentContext)
 
     const format = new ProofFormatSpec({

diff --git a/...fs/formats/presentation-exchange/__tests__/PresentationExchangeProofFormatService.test.ts b/...fs/formats/presentation-exchange/__tests__/PresentationExchangeProofFormatService.test.ts
@@ -166,7 +166,6 @@ describe('Presentation Exchange ProofFormatService', () => {
       const { attachment, format } = await pexFormatService.acceptRequest(agent.context, {
         proofRecord: mockProofRecord(),
         requestAttachment,
-        proofFormats: { presentationExchange: { credentials: [mockCredentialRecord] } },
       })
 
       expect(attachment).toMatchObject({

diff --git a/...rc/modules/proofs/protocol/v2/__tests__/v2-presentation-exchange-presentation.e2e.test.ts b/...rc/modules/proofs/protocol/v2/__tests__/v2-presentation-exchange-presentation.e2e.test.ts
@@ -222,16 +222,8 @@ describe('Present Proof', () => {
       state: ProofState.PresentationReceived,
     })
 
-    const {
-      proofFormats: { presentationExchange },
-    } = await proverAgent.proofs.selectCredentialsForRequest({
-      proofRecordId: proverProofExchangeRecord.id,
-    })
-
     await proverAgent.proofs.acceptRequest({
       proofRecordId: proverProofExchangeRecord.id,
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      proofFormats: { presentationExchange: { credentials: presentationExchange! } },
     })
 
     // Verifier waits for the presentation from the Prover