fix: changed test

openwallet-foundation · Mar 31, 2022 · 4f19ce6 · 4f19ce6
1 parent 27135cc
commit 4f19ce6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/core/src/modules/credentials/__tests__/CredentialService.test.ts b/packages/core/src/modules/credentials/__tests__/CredentialService.test.ts
@@ -1088,21 +1088,22 @@ describe('CredentialService', () => {
   })
 
   describe('deleteCredential', () => {
-    it('should delete credential from repository', async () => {
+    it('should call delete from repository', async () => {
       const credential = mockCredentialRecord()
       mockFunction(credentialRepository.getById).mockReturnValue(Promise.resolve(credential))
 
       const repositoryDeleteSpy = jest.spyOn(credentialRepository, 'delete')
       await credentialService.deleteById(credential.id)
-      expect(repositoryDeleteSpy).toBeCalledWith(credential)
+      expect(repositoryDeleteSpy).toHaveBeenNthCalledWith(1, credential)
     })
 
     it('deleteFromWallet parameter should call deleteCredential in indyHolderService', async () => {
+      const deleteCredentialMock = indyHolderService.deleteCredential as jest.Mock<Promise<void>, [string]>
       const credential = mockCredentialRecord()
       mockFunction(credentialRepository.getById).mockReturnValue(Promise.resolve(credential))
-      const indyHolderServiceDeleteCredentialSpy = jest.spyOn(indyHolderService, 'deleteCredential')
+
       await credentialService.deleteById(credential.id, true)
-      expect(indyHolderServiceDeleteCredentialSpy).toBeCalledWith(credential.id)
+      expect(deleteCredentialMock).toHaveBeenNthCalledWith(1, credential.id)
     })
   })
 

diff --git a/packages/core/src/modules/credentials/services/CredentialService.ts b/packages/core/src/modules/credentials/services/CredentialService.ts
@@ -804,7 +804,7 @@ export class CredentialService {
    *
    * @param credentialId the credential record id
    */
-  public async deleteById(credentialId: string, deleteFromWallet?: boolean) {
+  public async deleteById(credentialId: string, deleteFromWallet?: boolean): Promise<void> {
     const credentialRecord = await this.getById(credentialId)
 
     if (deleteFromWallet) {