Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loosen types on ble inbound and outbound transport and session #226

Conversation

berendsliedrecht
Copy link
Contributor

  • Types were unnecessarily strict and this loosens it a bit.
    • Now Peripheral and Central are both allowed for inbound and outbound as they both extend Ble

@berendsliedrecht berendsliedrecht requested a review from a team as a code owner September 18, 2023 07:43
@codecov-commenter
Copy link

Codecov Report

Merging #226 (8632b74) into main (15e9f1f) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          24       24           
  Lines        1241     1241           
  Branches      270      270           
=======================================
  Hits         1077     1077           
  Misses        164      164           

@berendsliedrecht berendsliedrecht merged commit 17c6203 into openwallet-foundation:main Sep 18, 2023
9 checks passed
@berendsliedrecht berendsliedrecht deleted the loosen-transport-types branch September 18, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants