Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OOB Connectionless Flow #973

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

cvarjao
Copy link
Contributor

@cvarjao cvarjao commented Sep 20, 2023

Summary of Changes

Fix a flow error where scanning an connectionless OOB QR Code with Proof Requested attached would show as "invalid QR Code" error

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@cvarjao cvarjao marked this pull request as ready for review September 20, 2023 14:45
@cvarjao cvarjao requested a review from a team as a code owner September 20, 2023 14:45
amanji
amanji previously approved these changes Sep 20, 2023
@jleach jleach changed the title OOB/Connectionless Flow feat: OOB Connectionless Flow Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #973 (bb3a534) into main (2cc0607) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files         176      176           
  Lines        5084     5084           
  Branches     1450     1451    +1     
=======================================
  Hits         3012     3012           
  Misses       2046     2046           
  Partials       26       26           
Files Coverage Δ
packages/legacy/core/App/navigators/RootStack.tsx 0.93% <0.00%> (ø)
packages/legacy/core/App/utils/helpers.ts 51.34% <0.00%> (+0.45%) ⬆️
packages/legacy/core/App/screens/Scan.tsx 44.92% <0.00%> (-2.05%) ⬇️

@bryce-mcmath bryce-mcmath self-requested a review September 21, 2023 11:41
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Clécio Varjão <[email protected]>
@cvarjao cvarjao force-pushed the issue/bc-wallet/1147 branch from 75c4c3c to 0fc74e0 Compare September 26, 2023 21:48
Signed-off-by: Clécio Varjão <[email protected]>
@bryce-mcmath bryce-mcmath self-requested a review September 27, 2023 00:01
@bryce-mcmath bryce-mcmath merged commit 0098986 into openwallet-foundation:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants