chore: combine genesis tx to JSON file #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanji
reviewed
Dec 13, 2022
scripts/make-blocks.js
Outdated
| let ledgers = [] | ||
|
|
||
| for (let t of targets) { | ||
| const aUrl = url.parse(t['genesisUrl']) |
There was a problem hiding this comment.
Any insight into why it's named this way?
There was a problem hiding this comment.
They're the networks I'm interested in being added to Bifold. I'll call it something more obvious.
jleach
force-pushed
the
chore/update-genesis-tx
branch
from
6ace841 to
0f69483
Compare
amanji
approved these changes
Dec 14, 2022
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
jleach
force-pushed
the
chore/update-genesis-tx
branch
from
0f69483 to
133f44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
To better automate keeping the genesis transaction up-to-date I'm propose merging them into a single JSON file that can easily be updated using the included JavaScript file
make-block.js. This script pull down the genesis files from the ledger monitor repo and then imports all the latest genesis transactions.Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.