Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: It is no longer possible to change the default language from the… #1245

Merged

Conversation

Sp0k
Copy link
Contributor

@Sp0k Sp0k commented Aug 23, 2024

Summary of Changes

Added the French and Brazilian Portuguese options back in the language selection screen

Related Issues

#1242

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach force-pushed the fix-language-settings branch from 4b79927 to 4ef2bf9 Compare August 27, 2024 16:13
Copy link

@bryce-mcmath bryce-mcmath self-requested a review September 3, 2024 16:11
@bryce-mcmath bryce-mcmath merged commit 8b97fd8 into openwallet-foundation:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants