[multi-tenancy] add profile resource management #928
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
| await profile.close() | ||
|
|
||
| if len(self.profiles) <= self.capacity: | ||
| break |
There was a problem hiding this comment.
It seems a bit odd that this will always iterate through the profiles, short-circuiting if there is one to be cleaned up and we are now below max capacity. Also self.profiles.items() will increase the refcount of the dict itself but not the entries it contains, as I understand it (and according to my test just now).
There was a problem hiding this comment.
I'm not that happy with this approach myself. I'll see if I can rework it a bit.
Do you have a suggestion on how to approach this? Do you think the way ledger handles refcounting will also work for here?
|
@TimoGlastra I think this feature is essential when hosting multi-tenancy enabled aca-py services. Do you have any plans to complete it? |
|
Yes definitely, good you bring it up. Just need to revisit the implementation and resolve the comment from Andrew |
|
Closing this PR as superseded by #1692 |
This PR adds a very simple approach to multi-tenant profile management. A
ProfileCacheis added that has a maxcapacity(initialized with 100 for now) and keeps count of references usingsys.getrefcount. It will close wallets when the capacity is exceeded and the profile is not used at the moment. The ledger implementation uses a custom refcounter using async context managers which may be nice to also use for this scenario. However this implementation allowed to build the cache on top of the profiles without modifying the profile itself.