Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow demo scripts to run outside of Docker; add command line parsing #84

Merged

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

@andrewwhitehead andrewwhitehead requested review from nrempel and ianco July 17, 2019 21:18
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   70.98%   70.98%           
=======================================
  Files         177      177           
  Lines        7524     7524           
=======================================
  Hits         5341     5341           
  Misses       2183     2183

@andrewwhitehead
Copy link
Contributor Author

For native Python run with GENESIS_URL=.. python3 -m runners.alice (for example) from the demo directory.

#(schema_id, credential_definition_id) = await agent.register_schema_and_creddef(
# "employee id schema", version, ["employee_id", "name", "date", "position"]
# )
# version = format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments safe to delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianco ?

@swcurran
Copy link
Contributor

@andrewwhitehead the instructions are not updated (and presumably I still need to run the pip3 install...) command, which I can do after. We will also have to make sure the instructions are adjusted to where the code is now placed. All works nicely in Docker and Play with Docker.

When I do run it using python, I get an python3-indy module not installed error message. I assume we need a pointer to somewhere in indy-sdk land for how to build the indy module and put it into our instructions. I'd say we go with this and I'll add a line that says "You have to build indy-sdk indy library" and ask for help from someone (Sam?) to provide the instructions.

However, even if we do that, we still won't have it working, because Sam has fixed this issue (the folders) but is speculating that the startup parameters are not right. Don't know if that is correct...

Perhaps that fastest thing we can do is get on a session with Sam to figure out why it is not working on his system and thus, with python generally? Any volunteers?

@swcurran swcurran self-requested a review July 18, 2019 00:23
Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked locally.

Running local ledger from the indy-sdk:

docker run -itd -p 9701-9708:9701-9708 indy_pool

Running local postgres:

docker run --name some-postgres -e POSTGRES_PASSWORD=mysecretpassword -d -p 5432:5432 postgres -c 'log_statement=all' -c 'logging_collector=on' -c 'log_destination=stderr'

Running local ledger browser from von-network:

GENESIS_FILE=/path/to/local-genesis.txt PORT=9000 REGISTER_NEW_DIDS=true python -m server.server

... and then ran the faber and alice roles from the demo directory:

python3 -m runners.faber --port 8020
python3 -m runners.alice --port 8030

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianco verified running on plain python. I verified running with Docker and Docker.

@swcurran swcurran merged commit 4f18e14 into openwallet-foundation:master Jul 18, 2019
@andrewwhitehead andrewwhitehead deleted the fix-demo-startup branch February 29, 2020 21:45
burdettadam pushed a commit to burdettadam/aries-cloudagent-python that referenced this pull request Sep 13, 2022
…/credential-attachments-verifier

Validate supplements upon proof request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants