match get-did-list to response "public" schema spec and fix misleadin…

[sklump]

…g description text

#676

Signed-off-by: sklump [email protected]

[codecov-commenter]

Codecov Report

Merging #681 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         251      251           
  Lines       13560    13560           
=======================================
  Hits        13423    13423           
  Misses        137      137           

[jcourt562]

Thanks I use a workaround to try and get the Verkey for each did to determine if it is on the ledger. I need to know to allow the user to request writing it even though they don't want it to be their "assigned" public DID. Fixing the returned types is extremely valuable for those using OpenAPI to generate wrappers so thanks again.

[sklump]

What do you want with verkeys that don't correspond to agent public DIDs? Typically these are obsolete; they have been superseded.

Do you need anything else here, or can you work with the current state?

[jcourt562]

So the scenario I am doing is that a user creates multiple private DIDs using POST /wallet/did/create. Then write some of these DIDs to the ledger using POST /ledger/register-nym. The intention for this could be for creating connections or use in create credential definitions with a different DID for various reasons (i.e avoiding correlation with multiple public DIDs in invitations or because they issue credentials for different organisations which require unique DIDs).

In order to show them which DIDs are on the ledger (i.e. and so can't be written again) for example if they want to swap their current DID in use, I need to know which ones are written to ledger. Since GET /wallet/did doesn't return an indication of which are written to ledger I am currently having to perform GET /ledger/did-verkey one each as a test. Is there a better way ? I assume GET /wallet/did even with filtering indicating public won't work as if it did it would make sense to return the "on ledger" status in the existing responses rather than just the indication for which did is currently being used by ACA-py (i.e which is what "public" seems to indicate) ?

Thanks

[sklump]

You are following the best practice as it stands.

We plan to revisit public/local DIDs after 0.5.4 because of the awkwardness you raise here. On-ledger or off-ledger ought to be in metadata and available via the wallet API. However, I suspect this will have a lot of tricky affected-bys and so it waits until we get the current release out.

[jcourt562]

Thanks for the feedback !

[sklump]

Please check your rocket chat for further discussion.