Fixed a bug that occurred when handling NoneType. #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minseong Jeong <[email protected]>
The code was too long, so it was treated as a variable. Signed-off-by: Minseong Jeong <[email protected]>
The code was too long, so it was treated as a variable. Signed-off-by: Minseong Jeong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 251 251
Lines 13560 13561 +1
=======================================
+ Hits 13423 13424 +1
Misses 137 137 |
sklump
reviewed
Aug 21, 2020
| @@ -329,8 +329,9 @@ async def create_presentation( | |||
| epoch_now = int(time.time()) | |||
|
|
|||
| non_revoc_interval = {"from": 0, "to": epoch_now} | |||
| non_revoked_value = presentation_request.get("non_revoked") | |||
There was a problem hiding this comment.
I can tighten this up without needing non_revoked_value while satisfying black. I will submit in a new PR.
|
#680 supersedes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A runtime error was found while testing by linking between the VCX library in the indy-sdk repository and Aries cloudagent.
That is, the problem occurred because the value of 'non_revoked' field was not initialized to '{}' and the value was set to 'None'.
This occurs when the value of the 'non_revoked' field in the presentation record is loaded in the process of sending presentation (/present-proof/records/{pres_ex_id}/send-presentation REST API).
When a presentation proof is requested using the VCX library, the 'non_revoked' field value in the record is set to the 'None' value.
So, you can see that the return value of the dict.get() function is set to 'None' instead of '{}'.
So, it works normally only when the part that checks the field is strengthened as follows.