Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint type merge #667

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Endpoint type merge #667

merged 2 commits into from
Aug 18, 2020

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Aug 17, 2020 •
edited
Loading

Merge current master into Dominic Wörner's PR#589 (which became #634) endpoint-type work en route to merging back into master, unit test coverage

Woerner Dominic (RBCH/PJ-IOT) and others added 2 commits July 29, 2020 14:52
@sklump sklump mentioned this pull request Aug 17, 2020
Closed
@sklump
Copy link
Contributor Author

sklump commented Aug 17, 2020

Merges current master into #634 in preparation for merge of this (endpoint-type) work back into aca-py master.

@sklump sklump requested a review from andrewwhitehead August 17, 2020 18:31
@domwoe
Copy link

domwoe commented Aug 18, 2020

Thanks!

@domwoe
Copy link

domwoe commented Aug 18, 2020

Is there a need to allow for provisioning with different endpoint types? Since only endpoint_type==EndpointType.ENDPOINT affects the wallet, I am guessing that there is no such need?

This could make sense. In particular if you want to do all ledger operations during provisioning

@sklump
Copy link
Contributor Author

sklump commented Aug 18, 2020

Is there a need to allow for provisioning with different endpoint types? Since only endpoint_type==EndpointType.ENDPOINT affects the wallet, I am guessing that there is no such need?

This could make sense. In particular if you want to do all ledger operations during provisioning

I think that could be separate PR though. This one introduces a significant change on its own. I can get on it once it's merged.

@andrewwhitehead andrewwhitehead merged commit 4a80d88 into openwallet-foundation:master Aug 18, 2020
@domwoe domwoe mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewwhitehead andrewwhitehead andrewwhitehead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sklump @domwoe @andrewwhitehead