allow forwarded messages to use existing connections and the outbound queue #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Curren <[email protected]>
Signed-off-by: Sam Curren <[email protected]>
Signed-off-by: Sam Curren <[email protected]>
Signed-off-by: Sam Curren <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 248 248
Lines 13260 13264 +4
=======================================
+ Hits 12843 12847 +4
Misses 417 417 |
sklump
previously approved these changes
Jul 24, 2020
| await responder.send(packed, connection_id=recipient.connection_id) | ||
| await responder.send( | ||
| packed, | ||
| connection_id=recipient.connection_id, |
There was a problem hiding this comment.
Looking at the responder code, I think you can pass connection_targets as target_list, instead of passing connection_id, and it would avoid the need to look up the connection information twice.
There was a problem hiding this comment.
I needed to pass connection_id as well, but it accepted both. Updated.
Signed-off-by: Sam Curren <[email protected]>
|
@andrewwhitehead -- good to go? This should be it for 0.5.4, I think. |
andrewwhitehead
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjustment allows the mediator forward function to work with endpoint-less connections, either via active connections with return route, or via the outbound queue. (Sending to an endpoint was already supported.)