-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revocation hotfixes #579
Revocation hotfixes #579
Conversation
Signed-off-by: sklump <[email protected]>
Signed-off-by: sklump <[email protected]>
Signed-off-by: sklump <[email protected]>
revoc_reg_id, | ||
cred_revoc_id, | ||
) | ||
except IndyError as error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is great.
Also note @esune I believe this should cure the problem you were seeing without any changes on your end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... then take the troublesome cred_rev_ids on the rev_reg_id and purge them via clear_pending_revocations API as per issue_credentials/v1_0/routes.py, submitting body
{
"rrid2crid": {
"<rev-reg-id>": ["<cred-rev-id>", "<cred-rev-id>", ...]
}
}
Looks good to me |
Signed-off-by: Andrew Whitehead <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 96.45% 96.46% +0.01%
==========================================
Files 247 247
Lines 13115 13166 +51
==========================================
+ Hits 12650 12701 +51
Misses 465 465 |
Publish any pending revocations for rev reg id on any revocation with publish=True.
Recover from revocation failures gracefully.
Allow clearing of pending revocations by rev reg id (null/empty for all) and by cred rev ids (null/empty for all)
Allow for granularity in publication of pending revocations by rev reg id (null/empty for all) and by cred rev ids (null/empty for all).
Demo touch-ups to match.