allow provision of local-only DID in wallet #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sklump <[email protected]>
sklump
commented
Jun 16, 2020
| @@ -25,8 +25,6 @@ async def handle(self, context: RequestContext, responder: BaseResponder): | |||
| if not context.connection_ready: | |||
| raise HandlerException("Cannot query routes: no active connection") | |||
|
|
|||
| # TODO implement pagination | |||
There was a problem hiding this comment.
Note that the storage query uses pagination: comment was obsolete
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 96.80% 96.76% -0.05%
==========================================
Files 240 240
Lines 12710 12727 +17
==========================================
+ Hits 12304 12315 +11
- Misses 406 412 +6 |
andrewwhitehead
approved these changes
Jun 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, ledger must be open on receiving presentation preview to check if revocation applies
Signed-off-by: sklump [email protected]