Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.1rc0 #3459

Merged
merged 3 commits into from
Jan 21, 2025
Merged

1.2.1rc0 #3459

merged 3 commits into from
Jan 21, 2025

Conversation

swcurran
Copy link
Contributor

Signed-off-by: Stephen Curran [email protected]

Signed-off-by: Stephen Curran <[email protected]>
@swcurran swcurran requested review from a team January 21, 2025 18:36
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm wondering if there's anywhere we can add a message about not using 1.2.0 for multi-tenant single-wallet deployments?

Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Contributor Author

Something like that on the Release 1.2.0 Changelog entry?

:alert: A bug in Release 1.2.0 prevents using the release with existing multi-tenant, single wallet deployments. Those requiring such support must skip Release 1.2.0 and move to Release 1.2.1rc0 or higher.

jamshale
jamshale previously approved these changes Jan 21, 2025
Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Contributor Author

Tweaked the worning to look better on mkdocs site.

@swcurran swcurran merged commit aa3a343 into openwallet-foundation:main Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants