Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit token for publishing #3407

Closed
wants to merge 1 commit into from
Closed

Add explicit token for publishing #3407

wants to merge 1 commit into from

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Dec 17, 2024

@ryjones ryjones requested review from swcurran and jamshale December 17, 2024 07:02
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the repository url need to be passed to pypa/gh-action-pypi-publish? I see the repository url defined in the environment section, but it's not used in the publish step.

@ryjones
Copy link
Contributor Author

ryjones commented Dec 17, 2024

Does the repository url need to be passed to pypa/gh-action-pypi-publish? I see the repository url defined in the environment section, but it's not used in the publish step.

I'm unsure. I think they are two different things. @jamshale ?

@jamshale
Copy link
Contributor

This would only need to be done for the 0.12.lts branch.

I'm not sure if we need to do this. I'm going to look at manually publishing for the backporting instead. I think it should be easy and we won't need to do it unless there's a critical problem for these LTS branches.

@swcurran
Copy link
Contributor

For the 0.11.lts branch, we’ll not need to do so again — LTS EoL is January 2025.

For the 0.12.lts branch, we have at least 9 more months. We’ll probably declare 1.1.x as the LTS branch, which will start the clock on ending 0.12.lts support.

@jamshale
Copy link
Contributor

I think this should work if we target 0.12.lts branch instead of main. I can open a new PR and try it. If it does work then we don't need to bug Ry to do it manually everytime.

@jamshale
Copy link
Contributor

Yay. This worked!

image

Thanks @ryjones . Going to close this PR.

@jamshale jamshale closed this Dec 17, 2024
@ryjones ryjones deleted the token-update branch December 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants