Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.1rc0 #3372

Merged
merged 7 commits into from
Dec 4, 2024
Merged

1.1.1rc0 #3372

merged 7 commits into from
Dec 4, 2024

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Dec 2, 2024

Signed-off-by: Stephen Curran [email protected]

@swcurran
Copy link
Contributor Author

swcurran commented Dec 2, 2024

Waiting for a merge of #3371 before taking of draft.

@swcurran swcurran marked this pull request as ready for review December 3, 2024 18:43
@swcurran swcurran requested review from a team December 3, 2024 18:43
dbluhm
dbluhm previously approved these changes Dec 3, 2024
@swcurran
Copy link
Contributor Author

swcurran commented Dec 3, 2024

@jamshale -- looks like we have a real fail here. Could you please investigate? I had thought it was a GitHub glitch -- I had another problem at the same time, so thought it might have been intermittent. Looks like it is in the special set of "pre-release" integration tests.

@swcurran
Copy link
Contributor Author

swcurran commented Dec 3, 2024

All seems happy until this revocation test:

Issue a credential with revocation, with the Issuer beginning with an offer, and then revoking the credential -- @2.1

7hBob.agent  | credential_id 57af3a1f-b503-444f-8b51-dd46fa52c6bd
7hBob.agent  | cred_def_id X2cqK2VzkjeRMqNQxfXArr:3:CL:2577542:Acme.agent.Schema_DriversLicense
7hBob.agent  | schema_id X2cqK2VzkjeRMqNQxfXArr:2:Schema_DriversLicense:1.0.1
INFO:aiohttp.access:172.17.0.1 [03/Dec/2024:20:22:04 +0000] "POST /webhooks/topic/issue_credential_v2_0/ HTTP/1.1" 200 111 "-" "Python/3.12 aiohttp/3.11.9"
7hAcme.agent | Credential: state = done, cred_ex_id = 6347d5d1-d30b-4db2-a5e5-e3aae081297d
    Then "Acme" revokes the credential                                                                                                      # features/steps/0453-issue-credential.py:154
      Traceback (most recent call last):
        File "/home/aries/.local/lib/python3.12/site-packages/behave/model.py", line 1329, in run
          match.run(runner.context)
        File "/home/aries/.local/lib/python3.12/site-packages/behave/matchers.py", line 98, in run
          self.func(context, *args, **kwargs)
        File "features/steps/0453-issue-credential.py", line 173, in step_impl
          print("rev_reg_id:", cred_exchange["indy"]["rev_reg_id"])
                               ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
      TypeError: 'NoneType' object is not subscriptable
      

@jamshale
Copy link
Contributor

jamshale commented Dec 3, 2024

I think the test is likely to do with an anoncreds --> indy test in the expanded release test set that I didn't update. I'll look into it today.

@swcurran swcurran marked this pull request as draft December 3, 2024 22:41
@swcurran swcurran marked this pull request as ready for review December 3, 2024 22:44
Copy link

sonarqubecloud bot commented Dec 3, 2024

@jamshale
Copy link
Contributor

jamshale commented Dec 3, 2024

anoncreds issuers now need to use the anoncreds issuance and presentation format. They can no longer use the existing indy format which funneled into the anoncreds handler.

This would be a breaking change, although I don't now if anyone is actually using anoncreds in production yet.

@swcurran
Copy link
Contributor Author

swcurran commented Dec 3, 2024

Is it OK to leave the Changelog as is for the RC0, and then adjust the wording for the official release?

@jamshale
Copy link
Contributor

jamshale commented Dec 3, 2024

Ya sounds good. No problem.

@swcurran swcurran merged commit 4559704 into openwallet-foundation:main Dec 4, 2024
11 checks passed
@@ -1,6 +1,6 @@
[tool.poetry]
name = "acapy_agent"
version = "1.1.0"
version = "1.1.1"
Copy link
Contributor

@ff137 ff137 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that this probably should've been 1.1.1rc0. Seems now 1.1.1 is already written to pypi (only matters if there's gonna be a diff between rc0 and 1.1.1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argghhhh…thanks for the heads up. We’ll have to decide what to do — likely go to 1.1.2, since that version is now burned.

Doh. Humans can be stoopid. Especially me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants