Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Rearrange connection record deletion after hangup #3310

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Oct 24, 2024

Resolves #3306

Originally, the hangup method would delete the associated connection record before posting the hangup request. This is evidently a mistake, since the hangup depends on the connection record.

Mostly it would work, since there is a delay in the deletion of the connection record reflecting in storage, but rearranging the delete after hangup is a simple fix to avoid the race condition.


Before:
Sample 500 error from our tests (in "Wait for pytest and print logs" step): https://github.com/didx-xyz/aries-cloudapi-python/actions/runs/11387403475/job/31682203816

After:
Our tests now pass when testing this fix: didx-xyz/aries-cloudapi-python#1138

Copy link

@jamshale jamshale merged commit 059448a into openwallet-foundation:main Oct 24, 2024
10 checks passed
@ff137 ff137 deleted the fix/3306 branch October 25, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 DIDRotate Hangup can sporadically raise 500 error
2 participants