Ensure that DAP_PORT is always an int #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
jamshale
approved these changes
Sep 18, 2024
|
ff137
pushed a commit
to ff137/acapy
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]> Co-authored-by: jamshale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now when the
--debugflag is used with the setDAP_PORTenv var will result in an exception since the port number will default to being a string rather than the required int type. The source of this error can be found hereThis PR simply converts the port number from an str into an int