Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Enable ARM-based ACA-Py artifacts by default by removing BBS+ Signatures as a default inclusion #3127

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .devcontainer/post-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ markers = [
"indy: Tests specifically relating to Hyperledger Indy SDK support",
"indy_credx: Tests specifically relating to Indy-Credx support",
"indy_vdr: Tests specifically relating to Indy-VDR support",
"ursa_bbs_signatures: Tests specificaly relating to BBS Signatures support",
"postgres: Tests relating to the postgres storage plugin for Indy"]
junit_family = "xunit1"
asyncio_mode = auto
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/run-integration-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ inputs:
TEST_SCOPE:
description: "Set of flags that defines the test scope"
required: false
default: "-t @PR"
default: "-t @PR -t ~@BBS"
IN_LEDGER_URL:
description: "URL to the von network ledger browser"
required: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integrationtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ jobs:
if: (steps.check_if_release.outputs.is_release == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')
uses: ./.github/actions/run-integration-tests
with:
TEST_SCOPE: "-t @Release"
TEST_SCOPE: "-t @Release -t ~@BBS"
8 changes: 4 additions & 4 deletions demo/features/0453-issue-credential.feature
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Feature: RFC 0453 Aries agent issue credential
| --public-did --multitenant | --multitenant | driverslicense | Data_DL_NormalizedValues |


@T003.1-RFC0453
@T003.1-RFC0453 @BBS
swcurran marked this conversation as resolved.
Show resolved Hide resolved
Scenario Outline: Holder accepts a deleted json-ld credential offer
Given we have "2" agents
| name | role | capabilities |
Expand Down Expand Up @@ -155,7 +155,7 @@ Feature: RFC 0453 Aries agent issue credential
| --public-did --cred-type json-ld --mediation | --mediation | driverslicense | Data_DL_NormalizedValues |
| --public-did --cred-type json-ld --multitenant | --multitenant | driverslicense | Data_DL_NormalizedValues |

@T003.1-RFC0453
@T003.1-RFC0453 @BBS
Scenario Outline: Issue a json-ld credential with the Issuer beginning with an offer
Given we have "2" agents
| name | role | capabilities |
Expand Down Expand Up @@ -193,7 +193,7 @@ Feature: RFC 0453 Aries agent issue credential
| --public-did --cred-type json-ld --multitenant --wallet-type askar-anoncreds | --multitenant --wallet-type askar-anoncreds | driverslicense | Data_DL_NormalizedValues |


@T003.1-RFC0453
@T003.1-RFC0453 @BBS
Scenario Outline: Issue a json-ld credential with the holder beginning with a request
Given we have "2" agents
| name | role | capabilities |
Expand Down Expand Up @@ -223,7 +223,7 @@ Feature: RFC 0453 Aries agent issue credential
| --public-did --cred-type json-ld --wallet-type askar-anoncreds | --wallet-type askar-anoncreds | driverslicense | Data_DL_NormalizedValues |


@T004-RFC0453
@T004-RFC0453 @BBS
Scenario Outline: Issue a credential with revocation, with the Issuer beginning with an offer, and then revoking the credential
Given we have "2" agents
| name | role | capabilities |
Expand Down
2 changes: 1 addition & 1 deletion demo/features/0454-present-proof.feature
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Feature: RFC 0454 Aries agent present proof
| Acme | --public-did --mediation --multitenant --wallet-type askar-anoncreds | --mediation --multitenant --wallet-type askar-anoncreds | driverslicense_v2 | Data_DL_MaxValues | DL_age_over_19_v2 |


@T001.2-RFC0454
@T001.2-RFC0454 @BBS
Scenario Outline: Present Proof json-ld where the prover does not propose a presentation of the proof and is acknowledged
Given we have "3" agents
| name | role | capabilities |
Expand Down
76 changes: 38 additions & 38 deletions demo/run_bdd
Original file line number Diff line number Diff line change
Expand Up @@ -38,44 +38,44 @@ do
fi
continue
;;
--self-attested)
SELF_ATTESTED=1
continue
;;
--trace-log)
TRACE_ENABLED=1
TRACE_TARGET=log
TRACE_TAG=acapy.events
continue
;;
--trace-http)
TRACE_ENABLED=1
TRACE_TARGET=http://${TRACE_TARGET_URL}/
TRACE_TAG=acapy.events
continue
;;
--webhook-url)
WEBHOOK_TARGET=http://${WEBHOOK_URL}
continue
;;
--debug-ptvsd)
ENABLE_PTVSD=1
continue
;;
--debug-pycharm)
ENABLE_PYDEVD_PYCHARM=1
continue
;;
--debug-pycharm-controller-port)
PYDEVD_PYCHARM_CONTROLLER_PORT=$2
SKIP=1
continue
;;
--debug-pycharm-agent-port)
PYDEVD_PYCHARM_AGENT_PORT=$2
SKIP=1
continue
;;
--self-attested)
SELF_ATTESTED=1
continue
;;
--trace-log)
TRACE_ENABLED=1
TRACE_TARGET=log
TRACE_TAG=acapy.events
continue
;;
--trace-http)
TRACE_ENABLED=1
TRACE_TARGET=http://${TRACE_TARGET_URL}/
TRACE_TAG=acapy.events
continue
;;
--webhook-url)
WEBHOOK_TARGET=http://${WEBHOOK_URL}
continue
;;
--debug-ptvsd)
ENABLE_PTVSD=1
continue
;;
--debug-pycharm)
ENABLE_PYDEVD_PYCHARM=1
continue
;;
--debug-pycharm-controller-port)
PYDEVD_PYCHARM_CONTROLLER_PORT=$2
SKIP=1
continue
;;
--debug-pycharm-agent-port)
PYDEVD_PYCHARM_AGENT_PORT=$2
SKIP=1
continue
;;
--timing)
if [ "$(ls -ld ../log | grep dr..r..rwx)" == "" ]; then
echo "Error: To use the --timing parameter, the directory '../log' must exist and all users must be able to write to it."
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ FROM python:${python_version}-slim-bullseye AS main
ARG uid=1001
ARG user=aries
ARG acapy_version
ARG acapy_reqs=[askar,bbs,didcommv2]
ARG acapy_reqs=[askar,didcommv2]

ENV HOME="/home/$user" \
APP_ROOT="$HOME" \
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.demo
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN pip install --no-cache-dir poetry

ADD README.md pyproject.toml poetry.lock ./

RUN poetry install --no-root --no-directory -E "askar bbs"
RUN poetry install --no-root --no-directory -E "askar"

ADD aries_cloudagent ./aries_cloudagent
ADD scripts ./scripts
Expand Down
Loading
Loading