-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add by_format to terse webhook for presentations #3081
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
@jamshale do you know if it's possible to ignore the SonarCloud error? It doesn't like that we don't explicitly set the user in the demo dockerfile .... |
Sonarcloud passing isn't actually required to merge. So we can just ignore this and approve/merge as normal. I don't think there's an easy way to ignore it through the sonarcloud UI. |
Is it easy to fix? Obvs if not, we can leave it — just wondering. |
Prob not difficult to fix but may be time consuming to figure it out. The dockerfies are all slightly different so we'd need to get them all lined up with each other or figure it out for each one. I suggest we just log a ticket for now ... |
The integration test failures are related to json-ld, I'll need to look into it ... |
Signed-off-by: Ian Costanzo <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to this so quickly
Fix for issue #3065
Note that this is for the 2.0 presentation protocol only, do we need to apply a similar fix for 1.0?
This adds the
by_format
attribute for all webhooks, not just for statusdone
, however the demo requires this to work with terse webhooks (and no additional calls to the api endpoints)Added
by_format
for issue cred as well - was failing in the demo for json-ld :-(Makes the terse webhooks slightly less terse, but is required if we want the webhook to contain "enough" info for the controller to respond to.