🩹 add exception handling to wallet-upgrade check #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <[email protected]>
|
jamshale
approved these changes
Jun 19, 2024
|
I'm still trying to wrap my head around how this problem is happening. But, this is an easy fix to get around the problem. Very unlikely the problem and this functionality would conflict. Especially for this upgrade which should happen in a few seconds maximum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for non-critical issue.
Currently, if something goes wrong with the
check_for_wallet_upgrades_in_progressmethod, then startup will be aborted. This PR just adds a try-except block, such that the exception is logged and startup can proceed.Relates to #3030