Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proof_key issuance option #2991

Closed

Conversation

PatStLouis
Copy link
Contributor

Following the discussions in PR #2348, here's my suggestion to add an optional field to specify a verkey to use when querying the wallet for the didInfo used in issuing credentials.

This would satisfy the requirements raised by @Jsyro and some of the work we are doing around binding did:web to a did:indy.

Please review and share some toughts @dbluhm @swcurran @jamshale @ianco @TimoGlastra .

This will also preserve this enabling feature from the deprecated /jsonld/sign endpoint, giving controllers flexibility while using other did methods.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dbluhm
Copy link
Contributor

dbluhm commented May 28, 2024

As discussed in the ACA-PUG call today, we're looking at adding similar functionality by making it possible to tag keys with their verification method IDs. This was something we needed in #2959 as well. We will work with @PatStLouis to make sure the required interface changes can make it into ACA-Py regardless of the ultimate fate of #2959 (if needed, we can break them out of that PR and open it separately).

@dbluhm
Copy link
Contributor

dbluhm commented Jul 2, 2024

@PatStLouis the DCv2 PR was just merged; I think there are some minor updates needed to make it so we can associate multiple kids with a key but otherwise the changes made their should support this use case. I propose we close this PR and create an issue to track that.

@dbluhm
Copy link
Contributor

dbluhm commented Jul 2, 2024

Issue opened; @PatStLouis if there's good reason to have this PR open, feel free to reopen.

@dbluhm dbluhm closed this Jul 2, 2024
@PatStLouis
Copy link
Contributor Author

@dbluhm that sounds good to me, thanks!

@PatStLouis PatStLouis deleted the pstlouis/sign-with-verkey branch October 17, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants